Skip to content

Move old payload classes#2022

Merged
fractalwrench merged 1 commit intomainfrom
move-old-payload-classes
Mar 13, 2025
Merged

Move old payload classes#2022
fractalwrench merged 1 commit intomainfrom
move-old-payload-classes

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

@fractalwrench fractalwrench commented Mar 12, 2025

Goal

Moves some classes that used to be JSON serialiazable but are no longer into the core/features modules.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 12, 2025 13:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (c659d7d) to head (0297322).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         464      464           
  Lines       10518    10512    -6     
  Branches     1556     1556           
=======================================
- Hits         8967     8962    -5     
  Misses        875      875           
+ Partials      676      675    -1
Files with missing lines Coverage Δ
...id/embracesdk/internal/payload/ApplicationState.kt 100.00% <ø> (ø)
...droid/embracesdk/internal/payload/LifeEventType.kt 100.00% <ø> (ø)
...android/embracesdk/internal/payload/AnrInterval.kt 87.50% <ø> (ø)
...e/android/embracesdk/internal/payload/AnrSample.kt 100.00% <ø> (ø)
...droid/embracesdk/internal/payload/AnrSampleList.kt 100.00% <ø> (ø)
...sdk/internal/payload/PushNotificationBreadcrumb.kt 75.00% <ø> (ø)
...ndroid/embracesdk/internal/payload/AppFramework.kt 100.00% <ø> (ø)
...id/embracesdk/internal/payload/EnvelopeResource.kt 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bidetofevil
bidetofevil approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the move-old-payload-classes branch from 8112cdb to 0297322 Compare March 13, 2025 09:47
@fractalwrench fractalwrench merged commit 409f448 into main Mar 13, 2025
10 checks passed
@fractalwrench fractalwrench deleted the move-old-payload-classes branch March 13, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fractalwrench @bidetofevil